Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug 1645 (Unsqueeze OpSet 11) #1661

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Fix bug 1645 (Unsqueeze OpSet 11) #1661

merged 4 commits into from
Apr 19, 2024

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Apr 18, 2024 •
edited
Loading

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Fixes #1645

Changes

  1. Add ONNX files with opset 11 & 16 for unsqueeze op
  2. Add tests
  3. Fix dim output dim and configuration for opset 11

Testing

  1. New tests
  2. run-checks

@codecov Codecov
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.42%. Comparing base (9fbcbed) to head (a664a2f).

Files Patch % Lines
crates/burn-import/src/onnx/dim_inference.rs 81.81% 4 Missing ⚠️
crates/burn-import/src/onnx/op_configuration.rs 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1661   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files         694      694           
  Lines       80675    80662   -13     
=======================================
- Hits        69719    69709   -10     
+ Misses      10956    10953    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

laggui
laggui approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just a minor change regarding the actual opset for the op (should be 13 not 16). Approving in advance.

I do have a question though: do we want to start supporting multiple opset versions for importing ops? What was the reasoning behind this one? I think it can easily explode and we might just accept recent opsets. Up for discussion.

crates/burn-import/onnx-tests/tests/unsqueeze/unsqueeze_opset16.onnx Show resolved Hide resolved
crates/burn-import/src/onnx/dim_inference.rs Show resolved Hide resolved
crates/burn-import/onnx-tests/build.rs Show resolved Hide resolved
@antimora antimora merged commit 1433284 into tracel-ai:main Apr 19, 2024
14 checks passed
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
@antimora @syl20bnr
Fix bug 1645 (Unsqueeze OpSet 11) (#1661)
02b0a18 
* Add unsqueeze opset 16 test

* Fix for unsqueeze opset 11

* Remove println statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laggui laggui laggui approved these changes

@nathanielsimard nathanielsimard Awaiting requested review from nathanielsimard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for unsqueeze ONNX opset 1
2 participants
@antimora @laggui